Update point 2 of Creating your first workflow#1529
Closed
shreeya-sengupta wants to merge 1 commit intogithub:mainfrom
Closed
Update point 2 of Creating your first workflow#1529shreeya-sengupta wants to merge 1 commit intogithub:mainfrom
shreeya-sengupta wants to merge 1 commit intogithub:mainfrom
Conversation
On reading point 2 of Creating your first workflow section it is not clear that the commit should not be done immediately on the same branch (point 2) and the user should go to point 3 before committing. Adding an extra line in point 2 to inculcate this clarity.
|
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Contributor
|
@shreeya-sengupta Thanks so much for opening a PR! I'll get this triaged for review 🌟 |
janiceilene
added
actions
Contributor
|
This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit. |
github-actions
bot
added
the
stale
Author
|
@janiceilene : Hi, thanks for adding it to the docs team reviews. Any further updates? Thanks |
janiceilene
removed
the
stale
Contributor
|
@shreeya-sengupta Thanks for your patience! Our small team is working our way through reviewing all of the amazing contributions ✨ |
Member
|
Thanks so much for opening this PR! We're not currently planning to change this right now. |
This was referenced Jun 19, 2022
This was referenced Jun 19, 2022
This was referenced Sep 30, 2022
jnidzwetzki
pushed a commit
to jnidzwetzki/docs
that referenced
this pull request
Oct 6, 2022
* Document cagg improvements Indexes can now be created directly on caggs by using the view name. `ORDER BY` is supported in general, not just in the ordered-set aggregates. * Apply suggestions from code review Co-authored-by: Lana Brindley <github@lanabrindley.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On reading point 2 of Creating your first workflow section it is not clear that the commit should not be done immediately on the same branch (point 2) and the user should go to point 3 before committing. Adding an extra line in point 2 to inculcate this clarity.
Why:
Improvement in the "Github Action - Quickstart" document, section "Creating your first workflow". To the best of my understanding issue need not be created for a document updation and only a PR request should suffice.
What's being changed:
On reading point 2 of Creating your first workflow section it is not clear that the commit should not be done immediately on the same branch (point 2) and the user should go to point 3 before committing. Adding an extra line in point 2 to inculcate this clarity.
Check off the following: